-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shrink gmtmex.c by growing gmtmex_parser.c to be included in GMT core #12
Comments
👋 Thanks for opening your first issue here! Please make sure you filled out the template with as much detail as possible. We appreciate that you took the time to contribute! |
The benefit of the above is you can write a short paragraph to tell people just make this 5-line file and compile it with max or similar. |
I don't think you can shrink it that much. If you move any |
Hm, well gmtmex_parser.c calls mexErrMsgTxt, mxCreateNumericMatrix and lots of things, so it is all requiring a matlab include file, so perhaps there is nothing we can supply that does not require mex include/lib? |
Yes, had forgotten about those. So, nope it seems there is nothing valuable that we can move. |
I will look but it reduces the scope. |
Description of the desired feature
The gmtmex.extension library with the mexFunction needs to be built using the user's MATLAB version. Hence, we want to move as much of the code in gmtmex.c into the gmtmex_parser.c as possible to keep things simple. It seems to me that the ultimate mexFunction would just be something like this:
Does gmtmex.c really need more in it, @joa-quim if we just place the rest in gmt_mexfunction and stick in the gmtmex_parser.c in libgmt?
The text was updated successfully, but these errors were encountered: