Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making -Xc illegal for modern mode not good in movie #34

Open
PaulWessel opened this issue Jun 14, 2023 · 6 comments
Open

Making -Xc illegal for modern mode not good in movie #34

PaulWessel opened this issue Jun 14, 2023 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@PaulWessel
Copy link
Member

Running the spinning Earth movie examples now gives this error:

gmt movie 2_earth.sh -C360p -T91 -M55,pdf -N2_earth
coast [ERROR]: Centered (-Xc) and fixed (-Xf) shifts are not available in modern mode

While this makes sense for modern mode in general (infinite paper size...) it makes no sense for movie since here we actually have a specific paper size. So somehow we need to allow that when a movie script is running. Of top of my head here are some options:

  1. Let movie set a environmental parameter and we check for that before disallowing -Xc -Xf
  2. Let movie (as it converts the main.sh to the actual script that runs in parallel) detect -Xc|f and append an undocumented ! which means "accept this option even in modern mode".
  3. Introduce -XC and -XF for this purpose in movie scripts.

I think (2) is pretty simple to implement and does not require users to do anything different (and is backward compatible). Option (3) fails that.

Thoughts?

@PaulWessel PaulWessel added the bug Something isn't working label Jun 14, 2023
@PaulWessel PaulWessel self-assigned this Jun 14, 2023
@PaulWessel
Copy link
Member Author

This implies a problem for workshop running 6.4 though: The scripts that ran last year now fails. I think the only option for the workshop is for me to use -X -Y without c but actually spell out what that center coordinates is. Right?

@Esteban82
Copy link
Member

Yes, it is problem. I had to change it for Indiana Jones' animations.
But, I think that for the workshop you should/could install gmt 6.4.

@Esteban82
Copy link
Member

Altough the users that install the dev version can have somo issues.

@PaulWessel
Copy link
Member Author

I think we must expect 6.4 and not dev versions. I will use -X6c -Y0.75c instead of -Xc -Yc for now and mention that we introduced a bug in 6.4 (actually, did not check that yet as it is not that long ago this fix happened) and that-Xc -Yc will be restored in 6.5. Also, I will mention that 6.5 allows narration track to be included.

@PaulWessel
Copy link
Member Author

Altough the users that install the dev version can have somo issues.

Dont think so; -X6c -Y0.75c works fine for everybody.

@PaulWessel
Copy link
Member Author

Solution was unlisted number 4:

Check if GMT->current.setting.ps_def_page_size is still 32767x32767 (modern mode) or is smaller under modern mode (movie case).

Will make PR for gmt on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants