Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get application version number setup in the *-app.xml #926

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

alamboley
Copy link
Contributor

No description provided.

@PrimaryFeather
Copy link
Contributor

PrimaryFeather commented Nov 18, 2016

Good idea, that's definitely helpful!
One suggestion: could you rename the property (and member variable) to just applicationVersion? For consistency with the other version property.
Thx!

@PrimaryFeather
Copy link
Contributor

One problem I just realized is that such a version information is only available in AIR. All other properties in that class currently work for both AIR and Flash. But there's no sensible fallback value for Flash in this case. 😕

@alamboley
Copy link
Contributor Author

Hi Daniel,
I just renamed the property. Yeah, it's true. Unfortunately there is no way to have the same info with FP.

@PrimaryFeather
Copy link
Contributor

Thanks for the update, Aymeric!

Yeah, it's true. Unfortunately there is no way to have the same info with FP.

Mhm, there's no way around that. However, it makes me wonder if this is the right place for this property. Plus, people might want other information from the application descriptor, too — and it would be weird if there were some day lots of properties in the SystemUtil that just wrap lookups into the XML.

It's actually a little weird that this property is not part of the flash.desktop.nativeApplication class (like applicationID)!

So I'm not entirely sure about it yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants