Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion/Discussion - XP storage mending #385

Open
Levertion opened this issue Apr 2, 2020 · 4 comments
Open

Suggestion/Discussion - XP storage mending #385

Levertion opened this issue Apr 2, 2020 · 4 comments
Labels
feature-update An additional feature has been added to a module

Comments

@Levertion
Copy link
Contributor

I cannot find any previous discussion about whether XP storage should support mending.

I would like it to support mending on withdrawal. This would allow better farms to be made utilising other modules (such as a Forterra farm which doesn't require owning very many pickaxes).

Issues:

  • Probably requires the forceloaded shulker box with /loot trick to change damage values in inventory. It might be possible without that in 1.15, but for 1.16 it would be required.
  • Makes xp storage even more strong, although really it just adds convenience. XP storage is already very strong however.

Further ideas:

  • Some way to make it only do mending (other than standing between two enderchests lol)
    Suggested UX: Place a sea lantern above the ender chest.
  • Similarly, some way to make it not do mending, if for some reason you wanted that (curse of binding armor piece with mending?)
    Suggested UX: Soul sand above the ender chest?
  • Make supporting mending more expensive. Either by requiring e.g. a diamond/netherite block above the ender chest or just not being as efficient

Thanks!

@Bloo-dev
Copy link
Member

Bloo-dev commented Apr 2, 2020

For the time being there is a temporary work around:

  • use a Liquid Tank and the module "Mending Tanks"

The reason why mending doesn't work with any of our xp-Storage modules is that the Experience Orbs dropped by them are purely decorational to prevent nearby players from stealing your xp.
I don't think any changes will be made to "emulate" mending, it's more likely that those xp orbs might get a real xp value.

@SpecialBuilder32
Copy link
Member

In previous versions at least, the player absorbed xp slower than 20hz, meaning that giving the orbs actual value resulted in an xp-swarm around the player. Not good for server performance and that swarm could also be leeched by another player.

@Levertion
Copy link
Contributor Author

The alternative of course is to file the Minecraft bug and then strongarm @boq or @slicedlime into fixing it (/s for that second half)

@BPR02
Copy link
Member

BPR02 commented Aug 27, 2021

This is easily possible in 1.17 using /item modify

@Bloo-dev Bloo-dev removed the question label Sep 30, 2022
@Bloo-dev Bloo-dev added the feature-update An additional feature has been added to a module label Jan 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-update An additional feature has been added to a module
Projects
None yet
Development

No branches or pull requests

4 participants