Apply socket io #122
Open
Apply socket io #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntment in the website the today's scheduale table updated with the new appointments
AlaaShurrab
reviewed
Apr 21, 2021
| io.on('connection', (socket) => { | ||
| socket.on('add appointment', (value) => { | ||
| if (new Date(value).toDateString() === new Date().toDateString()) { | ||
| io.sockets.emit('updateAppointments'); |
There was a problem hiding this comment.
why did you use io.sockets.emit while you can use io.emit directly
| const io = socketIO(server); | ||
| io.on('connection', (socket) => { | ||
| socket.on('add appointment', (value) => { | ||
| if (new Date(value).toDateString() === new Date().toDateString()) { |
There was a problem hiding this comment.
this condition although it is not that important here, is easy to bypass
but for other socket requests, you should make the io route to what the normal route do with the same amount of validation
| @@ -4,6 +4,7 @@ import moment from 'moment'; | |||
| import { useLocation } from 'react-router-dom'; | |||
| import { bool } from 'prop-types'; | |||
| import { message } from 'antd'; | |||
| import socketIOClient from 'socket.io-client'; | |||
There was a problem hiding this comment.
repeated code
isn't it better to create a folder IO and export the functions from it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply socket io