Add more opinionated eslint rules, update to Node 18 #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garrettjstevens
force-pushed
the
add_unicorn_eslint
branch
from
7d15777
to
cce622e
Compare
garrettjstevens
force-pushed
the
add_unicorn_eslint
branch
from
cce622e
to
e210881
Compare
garrettjstevens
force-pushed
the
add_unicorn_eslint
branch
from
e210881
to
f02ca5c
Compare
garrettjstevens
force-pushed
the
add_unicorn_eslint
branch
from
f2344de
to
3937d6e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables the recommended rules from
eslint-plugin-unicorn(and then disables a few that don't work with our setup).These rules are a bit more opinionated, but I think they result in more consistent and easy-to-read code. Some of the rules correct to syntax not available in Node 16, but since it's close to EOL anyway, this updates everything to use a minimum of Node 18.
This PR also enables one more opinionated rule that's not part of unicorn,
eslint-plugin-sort-destructure-keys.