Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI testing with GitHub Actions #124

Closed
tzanio opened this issue Dec 8, 2020 · 6 comments
Closed

Add CI testing with GitHub Actions #124

tzanio opened this issue Dec 8, 2020 · 6 comments

Comments

@tzanio
Copy link
Member

tzanio commented Dec 8, 2020

We should add smoke test for

  • building on Linux, Mac
  • code styling
  • ...
@tzanio tzanio mentioned this issue Dec 9, 2020
19 tasks
@tzanio tzanio changed the title add CI testing with GitHub Actions Add CI testing with GitHub Actions Dec 20, 2020
@tzanio
Copy link
Member Author

tzanio commented Mar 13, 2021

It will be great if we test the actual usage, e.g. compare screenshots of pre-defined datasets as a form of regression testing.

@tzanio
Copy link
Member Author

tzanio commented Mar 13, 2021

We should also test the glvis-js and pyglvis repos

@adrienbernede
Copy link
Contributor

adrienbernede commented May 11, 2021

Current status is that we have Github Actions to build glvis. This is not running or testing it, and definitely not comparing screenshots. GLVis-js and pyglvis is yet another topic.

I suggest we keep this issue open, or split it in 2 in GLVis:

and 2 in GLVis-js and pyglvis:

@tzanio
Copy link
Member Author

tzanio commented Jul 6, 2021

I think we can close this after #176 is merged. Do you agree @adrienbernede?

@adrienbernede
Copy link
Contributor

I agree! Awesome leap forward!

@tzanio
Copy link
Member Author

tzanio commented Aug 11, 2021

Discussion continued in #176

@tzanio tzanio closed this as completed Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants