[NDSL] UW Convection port #993
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QSatIce missing before test can be done
Verbose the README
…. Fails to verify at majority of points using original metric, has not been tested with new metrics. Error patterns of the ES tables suggest arise during math within qsat_liquid and qsat_ice. Errors are small (10^-4). Further testing using find_klcl is in process to see if these errors propogate further or are locked within QSat.
…cil to calculate QSat for entire field, or function can be called from within the stencil to calculate QSat at individual points. To use function, the QSat class must be initialized before stencil call and the tables must be passed down to the function as an input.
FlorianDeconinck
added
the
0 diff
FlorianDeconinck
requested changes
Sep 10, 2024
There was a problem hiding this comment.
To be merged after QSat #994
- Resolve merge conflict in
.gitignore - Merge
dsl/developand resolve conflicts - Run lint with
pre-commit run --all-files - Move the files in a UW directory and drop a README.md describing what's ported, what's missing and any additional notes (with date)
- Revert changes to
run_tests.sh - Revert adding
uwshcu.F90.SERwhich would be a separate PR for the serialization
added 2 commits
September 10, 2024 16:09
…deal with reshaping 2D and 3D variables in translate test before calling stencil computation.
|
Resolved merge conflict in .gitignore |
|
Merged with dsl/develop and resolved merge conflicts. Created UW directory and added README.md. |
|
Removed uwshcu.F90.SER |
… but errors are very very small.
…2/6 variables. Some errors are very small and likely stem from multiplication with constants.
…ble pass. Very small errors still exist in 'ssthl0_test' that likely stem from multiplication with constants. A bug was found which does not allow functions to be called within while loops. A workaround has been implemented where this applies and errors are raised if certain conditions are not met.
… at less than 1%. Switched ndsl branches to unstable/develop.
…st part of compute_uwshcu port.
… changed at some point.
…an 0.01% of grid points. Still need to raise errors when unported code is triggered and cleanup.
…f the compute_uwshcu are triggered that have not yet been ported.
… edit a few variable descriptions.
…omp into dsl/UW_convection
…in uwshcu.F90. Including 'roots', 'compute_alpha', and 'single_cin'. Some translate tests may fail due to nans.
…omp into dsl/UW_convection
… gridpoints, most likely due to mixed precision problem.
…u. Several functions fail at some gridpoints, but mostly passing overall. Moving on and will revisit failed tests later.
…ept the expected nans.
…ints except expected nans. Should be run with debug backend for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ported and verified two smaller functions in UW Convection port: slope and conden. Small errors still exist when running translate_conden.py, which likely stem from errors in the QSat function.