Fixed uninitialized tep and qp when wstar <= 0.001 #931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
narnold1
approved these changes
May 14, 2024
atrayano
added
Non 0-diff
sdrabenh
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When wstar <= 0.001, tep and qp were left uninitialized inside mpbl_depth. These two variables are used later. When the code is build debug, this resulted in NaNs being sent to dqsat. @wmputman and @narnold1 , could you please check if my choice if initialization makes sense...
This PR fixes #930, and quite possibly the issue inside MAPL_LocStream as reported multiple times by @dbarahon