small inconsistency in accounting for capac residual? #990
Labels
bug
Something isn't working
Non 0-diff
The changes in this pull request are non-zero-diff
question ❔
Further information is requested
@rdkoster:
Near the end of subroutine catchment(), we compute (total) RUNOFF as the sum of surface runoff and baseflow:
GEOSgcm_GridComp/GEOSagcm_GridComp/GEOSphysics_GridComp/GEOSsurface_GridComp/GEOSland_GridComp/GEOScatch_GridComp/catchment.F90
Line 1271 in d21d478
Immediately thereafter, we check for negligible amounts of CAPAC (<1e-10) and convert them into (total) RUNOFF:
GEOSgcm_GridComp/GEOSagcm_GridComp/GEOSphysics_GridComp/GEOSsurface_GridComp/GEOSland_GridComp/GEOScatch_GridComp/catchment.F90
Line 1273 in d21d478
Don't we also need to add CAPAC(N)/DTSTEP to RUNSRF (or, alternatively, to BFLOW) so as to maintain consistency with (total) RUNOFF?
The water amounts involved are probably so small that in practice nobody ever notices. But we go to the trouble of accounting for them in RUNOFF, so maybe it's worth to also adjust the runoff components for consistency.
Please advise, thanks
PS: Here's the full block of code for reference (lines 1271-1275 in today's version of the "develop" branch)
cc: @biljanaorescanin
The text was updated successfully, but these errors were encountered: