Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small inconsistency in accounting for capac residual? #990

Open
gmao-rreichle opened this issue Aug 30, 2024 · 0 comments
Open

small inconsistency in accounting for capac residual? #990

gmao-rreichle opened this issue Aug 30, 2024 · 0 comments
Labels
bug Something isn't working Non 0-diff The changes in this pull request are non-zero-diff question ❔ Further information is requested

Comments

@gmao-rreichle
Copy link
Contributor

@rdkoster:
Near the end of subroutine catchment(), we compute (total) RUNOFF as the sum of surface runoff and baseflow:


Immediately thereafter, we check for negligible amounts of CAPAC (<1e-10) and convert them into (total) RUNOFF:

Don't we also need to add CAPAC(N)/DTSTEP to RUNSRF (or, alternatively, to BFLOW) so as to maintain consistency with (total) RUNOFF?
The water amounts involved are probably so small that in practice nobody ever notices. But we go to the trouble of accounting for them in RUNOFF, so maybe it's worth to also adjust the runoff components for consistency.
Please advise, thanks

PS: Here's the full block of code for reference (lines 1271-1275 in today's version of the "develop" branch)

        RUNOFF(N) = RUNSRF(N)+BFLOW(N)
        IF(CAPAC(N).LT.1.E-10) THEN
           RUNOFF(N) = RUNOFF(N)+CAPAC(N)/DTSTEP
           CAPAC(N) = 0.0
           endif

cc: @biljanaorescanin

@gmao-rreichle gmao-rreichle added bug Something isn't working question ❔ Further information is requested Non 0-diff The changes in this pull request are non-zero-diff labels Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Non 0-diff The changes in this pull request are non-zero-diff question ❔ Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant