Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User friendly error for active rescue signup failure #409

Open
1 task
SuperManifolds opened this issue Nov 4, 2024 · 0 comments
Open
1 task

User friendly error for active rescue signup failure #409

SuperManifolds opened this issue Nov 4, 2024 · 0 comments
Labels
Meta | Good First Issue 🔰 An issue that is of small scope, and easily handled by a new contributor. Priority | High ⚠️ An issue or PR that requires immediate attention. Type | Enhancement ⚡ A PR that enhances an existing feature.
Milestone
2.15.0

Comments

@SuperManifolds
Copy link
Member

Description

The fuel rats account system will reject an attempt to create an account with a CMDR name that is currently the client of an active rescue, this is to stop clients from needlessly regestering an account on fuelrats.com just to be rescued which many try to do even though it is not necessary.
Currently the fuel rats website will show an unknown error when this happens, ideally the front end would catch this error and show a user friendly dialogue explaining what is happening.
The error from the API is a 403 with a pointer to /data/attributes/name
https://github.com/FuelRats/api.fuelrats.com/blob/3eb8610072937e483e27747d0edcb484045580b7/src/routes/Register.mjs#L69

Additional Information (optional)

No response

FuelRats IRC Nickname (optional)

No response

I can help!

  • I am willing to implement this feature, and submit it as a PR.
@SuperManifolds SuperManifolds added Meta | Needs Attention 🚨 An issue that requires the attention of the maintainers. Type | Feature Request ✨ An issue that requests a new feature. labels Nov 4, 2024
@UncleClapton UncleClapton added Priority | High ⚠️ An issue or PR that requires immediate attention. Type | Enhancement ⚡ A PR that enhances an existing feature. Meta | Good First Issue 🔰 An issue that is of small scope, and easily handled by a new contributor. and removed Meta | Needs Attention 🚨 An issue that requires the attention of the maintainers. Type | Feature Request ✨ An issue that requests a new feature. labels Nov 5, 2024
@UncleClapton UncleClapton added this to the 2.15.0 milestone Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Meta | Good First Issue 🔰 An issue that is of small scope, and easily handled by a new contributor. Priority | High ⚠️ An issue or PR that requires immediate attention. Type | Enhancement ⚡ A PR that enhances an existing feature.
Projects
None yet
Milestone
2.15.0
Development

No branches or pull requests
2 participants
@SuperManifolds @UncleClapton