Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TalkerView doesn't user overall theme colors #262

Open
Vera-Spoettl opened this issue Sep 13, 2024 · 2 comments
Open

TalkerView doesn't user overall theme colors #262

Vera-Spoettl opened this issue Sep 13, 2024 · 2 comments
Labels
awaiting On the list for consideration or merge ui/ux Related to package user interface and exp

Comments

@Vera-Spoettl
Copy link

Vera-Spoettl commented Sep 13, 2024

I'm using a custom theme for my app. While my app and the Talker Monitor take the colors from my theme, TalkerView doesn't.

Screenshots
My app :-)
image

Talker Monitor :-)
image

TalkerView :-(
image

I guess lines 33, 34 and 52 in talker_view_appbar.dart cause the problem.

Instead of using the talkerTheme, they should use the app's theme.

I tried to adjust the TalkerScreenTheme but that doesn't work in my case as the white text in the filter buttons is hardly not visible and I'd prefer a white background for the log data.
image

It would be great, if this could be fixed. :-)

@Vera-Spoettl
Copy link
Author

Just found PR https://github.com/Frezyx/talker/pull/242 by XanderD99.
I guess it will cover this problem.

@XanderD99
Copy link

Hi @Vera-Spoettl
That pr of me would indeed fix it as it would use your apps theme instead.

I however already made a previous PR that fixed some small ui inconsistencies and added a factory method to the TalkerScreenTheme. This I think should fix your issues as well.

If I recall correctly the AppBar should then use talkerTheme.backgroundColor.

  factory TalkerScreenTheme.fromTheme(ThemeData theme, [LogColors? logColors]) {
    return TalkerScreenTheme(
      backgroundColor: theme.colorScheme.surface,
      textColor: theme.colorScheme.onSurface,
      cardColor: theme.colorScheme.surface,
      logColors: logColors,
    );
  }

@Frezyx Frezyx added awaiting On the list for consideration or merge ui/ux Related to package user interface and exp labels Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting On the list for consideration or merge ui/ux Related to package user interface and exp
Projects
None yet
Development

No branches or pull requests

3 participants