BUGFIX: Don’t show same error message twice

Flowpack · Nov 4, 2024 · 6646240 · 6646240
1 parent b7b4ca8
commit 6646240
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 16 deletions.
diff --git a/...urces/Private/JavaScript/asset-collections/src/components/CreateAssetCollectionDialog.tsx b/...urces/Private/JavaScript/asset-collections/src/components/CreateAssetCollectionDialog.tsx
@@ -31,11 +31,8 @@ const CreateAssetCollectionDialog = () => {
             .then(() => {
                 Notify.ok(translate('assetCollectionActions.create.success', 'Asset collection was created'));
             })
-            .catch((error) => {
-                Notify.error(
-                    translate('assetCollectionActions.create.error', 'Failed to create asset collection'),
-                    error.message
-                );
+            .catch(() => {
+                return;
             });
     }, [setDialogVisible, createAssetCollection, title, selectedAssetCollection?.id, Notify, translate]);
 

diff --git a/Resources/Private/JavaScript/asset-collections/src/components/DeleteButton.tsx b/Resources/Private/JavaScript/asset-collections/src/components/DeleteButton.tsx
@@ -49,11 +49,8 @@ const DeleteButton: React.FC = () => {
                     );
                     setSelectedAssetCollectionAndTag({ tagId: null, assetCollectionId: null });
                 })
-                .catch((error) => {
-                    Notify.error(
-                        translate('assetCollectionActions.delete.error', 'Failed to delete asset collection'),
-                        error.message
-                    );
+                .catch(() => {
+                    return;
                 });
         }
     }, [

diff --git a/Resources/Private/JavaScript/asset-tags/src/components/CreateTagDialog.tsx b/Resources/Private/JavaScript/asset-tags/src/components/CreateTagDialog.tsx
@@ -28,8 +28,8 @@ const CreateTagDialog: React.FC = () => {
             .then(() => {
                 Notify.ok(translate('tagActions.create.success', 'Tag was created'));
             })
-            .catch((error) => {
-                Notify.error(translate('tagActions.create.error', 'Failed to create tag'), error.message);
+            .catch(() => {
+                return;
             });
     }, [Notify, setDialogState, createTag, dialogState, translate, selectedAssetCollection]);
     const setLabel = useCallback((label) => setDialogState((state) => ({ ...state, label })), [setDialogState]);

diff --git a/Resources/Private/JavaScript/asset-upload/src/components/Dialogs/NewAssetDialog.tsx b/Resources/Private/JavaScript/asset-upload/src/components/Dialogs/NewAssetDialog.tsx
@@ -55,8 +55,8 @@ const NewAssetDialog: React.FC = () => {
                     void refetch();
                 }
             })
-            .catch((error) => {
-                Notify.error(translate('fileUpload.error', 'Upload failed'), error);
+            .catch(() => {
+                return;
             });
     }, [uploadFiles, dialogState.files.selected, setFiles, Notify, translate, refetch]);
 

diff --git a/Resources/Private/JavaScript/media-module/src/components/Main/AssetActions.tsx b/Resources/Private/JavaScript/media-module/src/components/Main/AssetActions.tsx
@@ -29,8 +29,8 @@ const AssetActions: React.FC<ItemActionsProps> = ({ asset }: ItemActionsProps) =
             .then(() => {
                 Notify.ok(translate('assetActions.import.success', 'Asset was successfully imported'));
             })
-            .catch((error) => {
-                Notify.error(translate('assetActions.import.error', 'Failed to import asset'), error.message);
+            .catch(() => {
+                return;
             });
     }, [importAsset, asset, Notify, translate]);