Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Recommended by Pocket has vanilla/non-matching styling #375

Closed
1 task done
dominichayesferen opened this issue Aug 14, 2023 · 0 comments · May be fixed by #392
Closed
1 task done

[Bug] Recommended by Pocket has vanilla/non-matching styling #375

dominichayesferen opened this issue Aug 14, 2023 · 0 comments · May be fixed by #392
Labels
bug Something isn't working

Comments

@dominichayesferen
Copy link
Contributor

dominichayesferen commented Aug 14, 2023

Attention!

  • I undertand that Floorp is NOT supported on Windows 7/8.1 or lower.

Describe the bug

The 'Recommended by Pocket' section of New Tab has vanilla Firefox's styling, which makes it look kinda awful against new tab page backgrounds.

To Reproduce

  1. Be in a region where Recommended by Pocket exists, such as Britain
  2. Start a new Floorp profile

Expected behavior

It'll use white header text, and the posts themselves will look way more consistent with the rest of the NTP.

Screenshots

Screenshot_20230814_164813

OS Info

Feren OS 2023.04

Floorp Version

11.1.2 (Flathub)

Additional context

In case you don't have this in Japan, here's the style classes:

  • 'Recommended by Pocket': .section-title, chrome://activity-stream/content/css/activity-stream.css:2273
  • 'Learn more': .learn-more-link a, chrome://activity-stream/content/css/activity-stream.css:2704
  • Cards on this section: .ds-card-grid .ds-card, chrome://activity-stream/content/css/activity-stream.css:2712, chrome://activity-stream/content/css/activity-stream.css:2721
  • Cards' titles: .ds-card header
  • Cards' text: .ds-card p
  • Cards' websites/read-times: .ds-card .meta .source

about:config values:

  • Show sponsored stories: browser.newtabpage.activity-stream.showSponsored
  • Recommended by Pocket (enables the section this issue is about, on by default in available regions): browser.newtabpage.activity-stream.feeds.section.topstories
  • Show sponsored sites in top sites section: browser.newtabpage.activity-stream.showSponsoredTopSites

Style-values of settings in New Tab Page's settings:

  • The whole 'Recommended by Pocket' option: #pocket-section
  • Sponsored Top Sites checkbox: #sponsored-shortcuts and data-l10n-id="newtab-custom-sponsored-sites"

Same settings but in about:preferences:

  • 'Recommended by Pocket': data-subcategory="topstories"
  • Sponsored Top Sites checkbox: data-l10n-id="home-prefs-shortcuts-by-option-sponsored"
@dominichayesferen dominichayesferen added the bug Something isn't working label Aug 14, 2023
@dominichayesferen dominichayesferen changed the title [Bug] Recommended by Pocket has an incorrect text colour [Bug] Recommended by Pocket has vanilla/non-matching styling Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants