Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement cleanup strategy for closePortal in useFlatfile hook #83

Open
coderabbitai bot opened this issue Apr 10, 2024 · 0 comments
Open

Implement cleanup strategy for closePortal in useFlatfile hook #83

coderabbitai bot opened this issue Apr 10, 2024 · 0 comments

Comments

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Apr 10, 2024

There's a TODO comment in the hook within suggesting the need for a cleanup strategy, specifically for removing the iFrame/listener from the DOM. This is important to prevent potential memory leaks or unintended behavior.

Context: The TODO was highlighted during a review of PR #82, specifically in the discussion #82 (comment).

The issue involves deciding on and implementing a strategy to ensure that resources are properly cleaned up when the function is called. This may include removing iFrames and detaching event listeners that were added during the portal's operation.

This task is crucial for maintaining the integrity and performance of the application, preventing memory leaks, and ensuring that event listeners do not persist beyond their intended lifecycle.

Requested by: @bangarang

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants