Incompatibility with REI Dark Mode

[surprisedpika]

Describe the Bug

When viewing recipes through REI with Dark Mode enabled, certain item boxes are not correctly rendered as dark.

Reproduction Steps

1. Make sure REI and Create are downloaded
2. On the REI settings (right of search bar) select "Dark Theme"
3. View any recipe type added by Create using REI

Expected Result

The graphics should all update to a dark theme.

Screenshots and Videos

2022-05-17.16-09-58.mp4

Crash Report or Log

No response

Operating System

Windows 10

Mod Version

0.4.1

Minecraft Version

1.18.2

Other Mods

REI

Additional Context

No response

[JieningYu]

need to redo the textures used for rei because the og texture is white-gray based.

[labaredaf]

I made a resourcepack that """fixes""" it (only use it if REI's dark theme is enabled, as it overrides the textures and would make light theme look weird)
Create REI Dark Theme.zip

[maximumpower55]

I made a resourcepack that fixes it Create REI Dark Theme.zip

Could i pr this?

[JieningYu]

I made a resourcepack that fixes it Create REI Dark Theme.zip

Could i pr this?

but this pack override the original texture which is hacky.

[labaredaf]

I made a resourcepack that fixes it Create REI Dark Theme.zip

Could i pr this?

but this pack override the original texture which is hacky.

Yeah, it's only supposed to be used if REI's dark theme is going to be enabled all the time, in case a full fix is done feel free to use my textures though

[JieningYu]

Need to add a condition to detect if dark mode is enabled.

[maximumpower55]

Okay, And a fix to allow for both light and dark mode textures would just be a simple if statement

[maximumpower55]

The more i think about this, this is a issue with upstream (forge) create too, so i don't think we should fix it

[maximumpower55]

Nevermind im dumb, JEI doesn't have dark mode

[Skidamek]

Nevermind im dumb, JEI doesn't have dark mode

But rei is available for forge too

[maximumpower55]

Nevermind im dumb, JEI doesn't have dark mode

But rei is available for forge too

Yes but literally no one uses that

[electricsteve]

Nevermind im dumb, JEI doesn't have dark mode

But rei is available for forge too

Yes but literally no one uses that

that isn't true, it is used in modpacks like FTB SB3. Mainly for grouping of items.

[electricsteve]

I made a resourcepack that """fixes""" it (only use it if REI's dark theme is enabled, as it overrides the textures and would make light theme look weird) Create REI Dark Theme.zip

I am currently fixing this issue, so can i use your textures? edit: @labaredaf

[TropheusJ]

see #1616