Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NestableJarGenerationTask.Metadata record should be public for configuration cache support #1132

Open
lukebemish opened this issue Jun 24, 2024 · 1 comment

Comments

@lukebemish
Copy link
Contributor

This record https://github.com/FabricMC/fabric-loom/blob/dev/1.7/src/main/java/net/fabricmc/loom/build/nesting/NestableJarGenerationTask.java#L237 is currently protected. As it is used as an (albeit protected) task input type, gradle will attempt to construct a new one during restoration from configuration cache; it will fail to do so as the record is protected, and it does not create any sort of bouncer to its constructor in its generated task subclass. See https://gist.github.com/Nyfaria/1212eae73685830aeab58bce50cca4d1

@modmuss50
Copy link
Member

Thanks, as far as im aware the whole remap jar task + related stuff such as this is all thats left to deal with. Thankfully this seems quite easy to resolve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants