Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up of integration tests #476

Merged
merged 13 commits into from
Nov 26, 2024
Merged

Clean up of integration tests #476

merged 13 commits into from
Nov 26, 2024

Conversation

zapta
Copy link
Collaborator

@zapta zapta commented Nov 25, 2024

This PR focuses on cleaning up the integration tests. With this PR we cover packages operations, examples operations, and build/test/lint/report for ice40 and ecp5.

As part of the cleanup, the various paio text fixtures where consolidate into one called apio_runner which makes it easy to add new functionality and allows to wrap apio invocation with test code (e.g. to avoid extended PATH propogation from one test to the next).

Caveats:

  • We need a gowin test example apio-examples that has a testbench (similar to Alhambra II / ledon) so we can extend the project tests to gowing.
  • Apio doesn't handle well spaces in packages directory so the tests do not cover it (unicode is ok and is covered). I created an issue for this [BUG] Apio lint fails when the packages path in APIO_PACKAGES_DIR contains spaces. #474 and added a check that causes apio to exist with an error message if a home, packges, or project directory contains a white space.

to the tar extractor a 'trusted_filter' mode, if the python version is
greater or equal 12.0. We expect that this will preserve the existing tar
default arvhining mode in future version of python.
… check'

and 'make check_all' stays the same and tests all tests, offline and online.
developement process including building, linting, and testing.
Now also restoring the system path on each apio command to prevent
the repeated extension of the path on each command (this happens
only in testing where pytest invokes apio multiple times within
the same python process).
This commit redirects the 'examples' packge to my own provate repo
until the official one will be update with the latest PR.
home, packages, and project (was util.py) and apio exits with an error
if any of them contains a white space. This is a temporary error
until we will resolve FPGAwars#474
@Obijuan Obijuan merged commit 2d6b599 into FPGAwars:develop Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants