Skip to content
This repository has been archived by the owner on Feb 21, 2022. It is now read-only.

Make name argument to Functional optional #58

Open
wence- opened this issue Aug 26, 2020 · 0 comments
Open

Make name argument to Functional optional #58

wence- opened this issue Aug 26, 2020 · 0 comments

Comments

@wence-
Copy link
Collaborator

wence- commented Aug 26, 2020

When building specific functionals, we pass a name to the superclass constructor that is just a label.
A few of these superclass init calls have a functional name that doesn't match the class name. AFAICT this name is just an arbitrary label that one attaches, so it doesn't have to match.

To avoid this, we could make it an optional argument, and do:

class Functional:
    def __init__(self, ..., functional_type=None):
        ...
        self.functional_type = functional_type or type(self).__name__

Originally posted by @wence- in #56 (comment)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant