Add variable to toggle skipping dot text #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thearst3rd
force-pushed
the
toggle-dot-skip
branch
from
82b6df9
to
5cf9a71
Compare
|
I believe this PR still has a bug involving taking little/big warp gates, the music that was previously playing can persist after loading the next level. Or maybe it's when combined with |
|
I think background songs can't fade out and unload themselves until they finish fading in (which typically takes a few seconds), meaning if the song changes before the song completely fades in, it will get stuck playing. |
|
Oh yeah forgor to update here. Basically what Jenna said, I don't think this PR is the cause of that music bug since I did some testing and got it to happen with just warps/loads as I suspected. It having to do with fade in makes sense to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a variable which toggles the dot screen loading skip. Closes #7
By hooking
ChangeLeveland interceptingPlayerManager.Action, this PR also prevents the game from entering the dot loading screen at all (when the variable is true), rather than showing it for one frame when taking little or big warp gates. It subsequently fixes a bug where taking a little or big warp gate would cause the ambient noise of that dot loading screen to be present until the game is closed - apparently that sound doesn't get turned off by settingGameManager.DotLoadingto false.