Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Salvation should use "old dps calculation" #100

Open
haifron opened this issue Nov 27, 2022 · 2 comments
Open

Salvation should use "old dps calculation" #100

haifron opened this issue Nov 27, 2022 · 2 comments

Comments

@haifron
Copy link

haifron commented Nov 27, 2022

Since salvation ('XAB2307') has split projectiles, it should be in this list, as the current calculation means the dps number displayed on its database entry is 1/36th of the value.
(7920 damage every 3.1 seconds is much more than 70.97 dps).
The other units with splitting projectiles are all in the special list.

@haifron haifron closed this as completed Nov 27, 2022
@haifron
Copy link
Author

haifron commented Nov 27, 2022

I didn't mean to close this.

However, the dps calculations for units with splitting projectiles can be improved more than just implementing the above change. If I had the ability to create a branch I could change it so that the "special" input is not required - or maybe just required for the mercy -and the other "special" units use the more accurate dps calculations in dps.js that are based on sim steps.

Basically, could my account get permission to create a branch so I could directly write changes?

@spooky spooky reopened this Nov 28, 2022
@spooky
Copy link
Collaborator

spooky commented Nov 28, 2022

Hi @haifron I believe you should be able to fork the repo, then create a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants