Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect game visibility #50

Open
micheljung opened this issue Mar 29, 2018 · 0 comments
Open

Respect game visibility #50

micheljung opened this issue Mar 29, 2018 · 0 comments

Comments

@micheljung
Copy link
Member

Currently, the server broadcasts all games to all players. However, games marked as PRIVATE should not be broadcasted at all and games marked as FRIENDS should only be sent to friends.

  1. Remove the unused com.faforever.server.game.GameAccess
  2. Don't serialize visibility when sending games to client (in com.faforever.server.integration.legacy.transformer.GameResponsesTransformer#game)
  3. Implement a method similar to com.faforever.server.game.GameService#markDirty that allows specifying a list of players to send to
  4. Extend com.faforever.server.client.DelayedResponse so that a list of receivers can be specified. The list should be nullable (so make its getter return an Optional), in which case it's considered a broadcast (document this in the getter)
  5. Refactor com.faforever.server.client.ClientService#broadcastDelayedResponses so that it either broadcasts the response or sends it to the list of recipients.
  6. Adjust and add unit tests accordingly
@micheljung micheljung added this to the v1.0 milestone Mar 29, 2018
@micheljung micheljung modified the milestones: v1.0, v1.1, v1.2 Apr 8, 2018
@micheljung micheljung modified the milestones: v1.2, v1.3 Apr 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant