Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alter fillpatch and boundary plane calls for overset simulations #1358

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

mbkuhn
Copy link
Contributor

@mbkuhn mbkuhn commented Nov 19, 2024

Summary

Because exawind-driver calls exchange_solution (and thereby, fillpatch) more than the plain AMR-Wind algorithm, and at slightly different instances in the time step, the Tioga Interface calls to fillpatch need to be made smarter to use the correct time in the algorithm. This hinges on the advance_states call that occurs at the beginning of the timestep. On top of that, the treatment of reading boundary plane data needs to be modified because of when pre_advance and exchange_solution calls happen from the overset solver.

Pull request type

Please check the type of change introduced:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Checklist

The following is included:

  • new unit-test(s)
  • new regression test(s)
  • documentation for new capability

This PR was tested by running:

  • the unit tests
    • on GPU
    • on CPU
  • the regression tests
    • on GPU
    • on CPU

Additional background

Without this fix, the overset solver fails an assert when reading boundary planes in AMR-Wind.

amr-wind/CFDSim.H Outdated Show resolved Hide resolved
@marchdf
Copy link
Contributor

marchdf commented Nov 20, 2024

I like where this is going. I just had a minor thought on clarity of naming functions.

@mbkuhn
Copy link
Contributor Author

mbkuhn commented Nov 20, 2024

The way I set it up should still be correct with multiple iterations in AMR-Wind, too

@mbkuhn mbkuhn changed the title skip populate_data if requested time is after interpolate time Alter boundary plane calls for overset simulations Nov 27, 2024
@mbkuhn mbkuhn changed the title Alter boundary plane calls for overset simulations Alter fillpatch and boundary plane calls for overset simulations Nov 27, 2024
@mbkuhn mbkuhn marked this pull request as ready for review November 27, 2024 17:07
@mbkuhn
Copy link
Contributor Author

mbkuhn commented Nov 27, 2024

it would be good to accompany this with an exawind-driver reg test

@marchdf
Copy link
Contributor

marchdf commented Nov 27, 2024

Good work! 100% tests passed, 0 tests failed out of 136

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants