Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing check for 8.33mS marking before checking address for sdi12 slave/sensor #121

Open
ZachaRuba opened this issue Apr 18, 2023 · 1 comment

Comments

@ZachaRuba
Copy link

Hello,

I did not see anywere in your library a check for marking before handling a command when using as an sdi12 sensor. This can cause problems when commands end with the same address as your sensor. For example, sensor address is 0. If there are multiple sensors on the dataline, you might receive 1D0! In this case, your sensor might respond with an acknowledgement, 0! and corrupt the response from the other sensor.

https://www.sdi-12.org/archives_folder/SDI-12%20Specification%201.3%20July%2018%202005.pdf
image

@ZachaRuba
Copy link
Author

Here is a project that is intended for an SDI-12 slave using a PIC microcontroller. You can see that when processing commands, they are looking for a marking.
https://github.com/RxTx1200/SDI-12_slave/blob/master/command.c#L16
https://github.com/RxTx1200/SDI-12_slave/blob/master/main.c#L155

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant