Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

See our fork #28

Open
robin-swift opened this issue Nov 10, 2021 · 1 comment
Open

See our fork #28

robin-swift opened this issue Nov 10, 2021 · 1 comment

Comments

@robin-swift
Copy link

I'm considering streamlining the project by using a wrapper around libembroidery to make our version of EmbroideryIO for the mobile viewer. We wouldn't have to replace it all in one go, so it would help to have your @tatarize help with swapping out the Java wrapped functions.

@tatarize
Copy link
Contributor

Since I wrote this version later and based on libembroidery's work it has a built in encoder and the rest of the tweaks that I realized were needed this is going to be, at present, a better version. Since there's a series of small bugs in the libembroidery reading and writing schemes that were fixed in the intervening years. Also, part of the reason for needing this is the android code doesn't really shift easily to C++ or C. Hooks to natives are remarkably harder and it's significantly easier to have a java version of the same code written in native Java 6.

It's entirely possible to wrap that stuff in an NDK and use libembroidery once that library is up to more modernish standards or superior to this. Though that would likely happen within your fork as this would remain the same as it's been for years now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants