Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework how lamps and the lamp controller function #1375

Open
pat2rome opened this issue Aug 19, 2022 · 0 comments
Open

Rework how lamps and the lamp controller function #1375

pat2rome opened this issue Aug 19, 2022 · 0 comments

Comments

@pat2rome
Copy link

The lamp controller was a nice idea in theory, but in practice, the way it's implemented makes AA lamps incredibly inconvenient. It works as is for only one case: when you have a bunch of lamps all side by side with no gaps. However, given the nature of lighting in Minecraft, this type of setup is incredibly rare. If you place lamps the way that the vast majority of players do, you need a controller on every single lamp. This takes up way too much space and resources.

To solve this issue, I proposed two changes:

  1. Make lamps respond directly to a redstone signal, the way vanilla lamps and most other mods' full block lights do.
  2. Make the controller check for lamps to light within a certain radius, in addition to keeping the current method of lighting all lamps touching the lamp the controller is on. This way, the controller fulfills its intended function of saving you from having to run a redstone signal to every single lamp, but does so in a way that allows much more flexibility in how lamps are placed (and keeps any current setups working as they always have).

I can add screenshots of what I mean if necessary, or clarify any other way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant