Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Make the <version> cli parameter optional #10

Open
TurinTuramba opened this issue Jun 6, 2019 · 3 comments
Open

[Enhancement] Make the <version> cli parameter optional #10

TurinTuramba opened this issue Jun 6, 2019 · 3 comments
Labels
enhancement New feature or request

Comments

@TurinTuramba
Copy link

Hello,

please make the cli parameter optional, because the version information are already in the composer.json file.
At the moment it is possible for example to push the version 1.0.0 with the cli-version 2.0.0 this is ambiguous and irritating.

Thx
Roland
@Elendev
Copy link
Owner

Elendev commented Jun 6, 2019

Hi @TurinTuramba, it's a good idea and I'll take a look as soon as I have some time to address this issue and make the version optional if such parameter is provided in the composer.json file.

@Elendev Elendev added the enhancement New feature or request label Jun 6, 2019
@ghost
Copy link

ghost commented Nov 12, 2019

Hi, just chipping in on this issue.
We forked this repository and maintain our own internal branch which is particularly aimed at running this in GitLab CI. We made this parameter sort-of optional. It's required when the CI_COMMIT_TAG environment variable is not present (E.G. when not running on a release tag).

LeJeanbono added a commit to LeJeanbono/composer-push that referenced this issue Oct 13, 2021
@LeJeanbono
Elendev#10 Make the <version> cli parameter optional
e82e02e
Elendev pushed a commit that referenced this issue Oct 13, 2021
@LeJeanbono
#10 Make the <version> cli parameter optional (#56)
685b40c 
* #10 Make the <version> cli parameter optional
Co-authored-by: Jonas Renaudot <[email protected]>
LeJeanbono added a commit to LeJeanbono/composer-push that referenced this issue Oct 15, 2021
@LeJeanbono
Elendev#10 Make the <version> cli parameter optional
f5299f3
@tm1000
Copy link
Collaborator

tm1000 commented Dec 28, 2022

This was resolved in #56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tm1000 @Elendev @TurinTuramba