Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems with team_id being empty #114

Open
thorgrin opened this issue Aug 2, 2019 · 0 comments
Open

Problems with team_id being empty #114

thorgrin opened this issue Aug 2, 2019 · 0 comments

Comments

@thorgrin
Copy link
Collaborator

thorgrin commented Aug 2, 2019

I've recently pushed a fix for links to files which handles team_id being an empty string. However, it is probably a bigger problem as stated by

		//FIXME: in v4 api team_id is NULL for group chats, that breaks the code in many places.
		//       should be rewritten.

		//if (team_id == NULL || strlen(team_id) == 0) {
		//	team_id = mm_get_first_team_id(ma);
		//}

What would happen when we added this check whenever ma->channel_teams is written to? I've tried it and it solved my problem at a root, but there are probably side effects which I cannot see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant