From 6c7ecf62ddb7e742a4b993ec9f351d6cd7025a93 Mon Sep 17 00:00:00 2001 From: Keith Oleson Date: Wed, 25 Sep 2024 11:19:25 -0600 Subject: [PATCH 1/4] PPE change to sa_leaf --- src/biogeophys/CanopyFluxesMod.F90 | 1 + 1 file changed, 1 insertion(+) diff --git a/src/biogeophys/CanopyFluxesMod.F90 b/src/biogeophys/CanopyFluxesMod.F90 index a969dc0583..0c5431728d 100644 --- a/src/biogeophys/CanopyFluxesMod.F90 +++ b/src/biogeophys/CanopyFluxesMod.F90 @@ -753,6 +753,7 @@ subroutine CanopyFluxes(bounds, num_exposedvegp, filter_exposedvegp, .or. dbh(p) < min_stem_diameter) then frac_rad_abs_by_stem(p) = 0.0_r8 sa_stem(p) = 0.0_r8 + sa_leaf(p) = sa_leaf(p) + esai(p) endif ! if using Satellite Phenology mode, calculate leaf and stem biomass From 9f4844cbf5d55db7768e13086786eab13d08f03b Mon Sep 17 00:00:00 2001 From: Samuel Levis Date: Mon, 14 Oct 2024 12:07:57 -0600 Subject: [PATCH 2/4] Draft ChangeLog/Sum --- doc/ChangeLog | 68 +++++++++++++++++++++++++++++++++++++++++++++++++++ doc/ChangeSum | 1 + 2 files changed, 69 insertions(+) diff --git a/doc/ChangeLog b/doc/ChangeLog index e6804811d2..02f7fa763f 100644 --- a/doc/ChangeLog +++ b/doc/ChangeLog @@ -1,4 +1,72 @@ =============================================================== +Tag name: ctsm5.3.008 +Originator(s): olyson (Keith Oleson,UCAR/TSS) +Date: Mon 14 Oct 2024 11:56:12 AM MDT +One-line Summary: PPE change to sa_leaf in CanopyFluxesMod.F90 + +Purpose and description of changes +---------------------------------- + + Add change to sa_leaf that was in PPE branch but did not get on master. + + +Significant changes to scientifically-supported configurations +-------------------------------------------------------------- + +Does this tag change answers significantly for any of the following physics configurations? +(Details of any changes will be given in the "Answer changes" section below.) + + [Put an [X] in the box for any configuration with significant answer changes.] + +[X] clm6_0 + +[X] clm5_1 + +[X] clm5_0 + +[X] ctsm5_0-nwp + +[X] clm4_5 + + +Bugs fixed +---------- +List of CTSM issues fixed (include CTSM Issue # and description) [one per line]: + Fixes #2777 + + +Testing summary: +---------------- + + [PASS means all tests PASS; OK means tests PASS other than expected fails.] + + regular tests (aux_clm: https://github.com/ESCOMP/CTSM/wiki/System-Testing-Guide#pre-merge-system-testing): + + derecho ----- + izumi ------- + + +Answer changes +-------------- + +Changes answers relative to baseline: Yes + + Summarize any changes to answers, i.e., + - what code configurations: All + - what platforms/compilers: All + - nature of change: larger than roundoff/same climate) + + The changes in answers are explained in this post: + https://github.com/ESCOMP/CTSM/issues/2777#issuecomment-2371697380 + + +Other details +------------- +Pull Requests that document the changes (include PR ids): + https://github.com/ESCOMP/ctsm/pull/2788 + +=============================================================== +=============================================================== Tag name: ctsm5.3.007 Originator(s): slevis (Samuel Levis,UCAR/TSS,303-665-1310) Date: Mon 13 Oct 2024 11:04:18 AM MDT diff --git a/doc/ChangeSum b/doc/ChangeSum index 7d01340622..5698b8654f 100644 --- a/doc/ChangeSum +++ b/doc/ChangeSum @@ -1,5 +1,6 @@ Tag Who Date Summary ============================================================================================================================ + ctsm5.3.008 olyson 10/14/2024 PPE change to sa_leaf in CanopyFluxesMod.F90 ctsm5.3.007 slevis 10/14/2024 Clm60 finidat updates for ne30, f09, f19 grids ctsm5.3.006 samrabin 10/11/2024 Merge b4b-dev ctsm5.3.005 erik 10/10/2024 Hardcoded tuning adjustments for Leung_2024 dust emissions From 77fdb8d07e6a0dfb674e0da5d11939cdf20e74c3 Mon Sep 17 00:00:00 2001 From: Samuel Levis Date: Mon, 14 Oct 2024 13:14:09 -0600 Subject: [PATCH 3/4] Updated ChangeLog from Keith Oleson's review --- doc/ChangeLog | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/doc/ChangeLog b/doc/ChangeLog index 02f7fa763f..986f58973d 100644 --- a/doc/ChangeLog +++ b/doc/ChangeLog @@ -1,7 +1,7 @@ =============================================================== Tag name: ctsm5.3.008 Originator(s): olyson (Keith Oleson,UCAR/TSS) -Date: Mon 14 Oct 2024 11:56:12 AM MDT +Date: Mon 14 Oct 2024 01:08:47 PM MDT One-line Summary: PPE change to sa_leaf in CanopyFluxesMod.F90 Purpose and description of changes @@ -18,15 +18,15 @@ Does this tag change answers significantly for any of the following physics conf [Put an [X] in the box for any configuration with significant answer changes.] -[X] clm6_0 +[ ] clm6_0 -[X] clm5_1 +[ ] clm5_1 -[X] clm5_0 +[ ] clm5_0 -[X] ctsm5_0-nwp +[ ] ctsm5_0-nwp -[X] clm4_5 +[ ] clm4_5 Bugs fixed @@ -56,8 +56,10 @@ Changes answers relative to baseline: Yes - what platforms/compilers: All - nature of change: larger than roundoff/same climate) - The changes in answers are explained in this post: + The changes in answers are explained in this post https://github.com/ESCOMP/CTSM/issues/2777#issuecomment-2371697380 + and the diagnostics are here + https://webext.cgd.ucar.edu/I2000/ctsm53n04ctsm52028_f09_saleaf/lnd/ctsm53n04ctsm52028_f09_saleaf_2000_2001_2004-ctsm53n04ctsm52028_f09_2000_2001_2004/setsIndex.html Other details From ea0dadda04ed84814c8c40e9364e7165566d6ebb Mon Sep 17 00:00:00 2001 From: Samuel Levis Date: Mon, 14 Oct 2024 16:05:22 -0600 Subject: [PATCH 4/4] Final ChangeLog --- doc/ChangeLog | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/doc/ChangeLog b/doc/ChangeLog index 986f58973d..bfaa2e71f7 100644 --- a/doc/ChangeLog +++ b/doc/ChangeLog @@ -1,7 +1,7 @@ =============================================================== Tag name: ctsm5.3.008 Originator(s): olyson (Keith Oleson,UCAR/TSS) -Date: Mon 14 Oct 2024 01:08:47 PM MDT +Date: Mon 14 Oct 2024 04:03:26 PM MDT One-line Summary: PPE change to sa_leaf in CanopyFluxesMod.F90 Purpose and description of changes @@ -42,8 +42,8 @@ Testing summary: regular tests (aux_clm: https://github.com/ESCOMP/CTSM/wiki/System-Testing-Guide#pre-merge-system-testing): - derecho ----- - izumi ------- + derecho ----- OK + izumi ------- OK Answer changes