-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unknown SoC, Technology, and Microarchitecture on SpacemiT K1/M1 #286
Comments
Thanks for the report, can you post the output of |
|
I've pushed a fix in branch Can you also provide the output of Also, I used your logo but it's too big indeed. Width is fine I think but it's too tall, it shouldn't be taller than 18 characters long. |
FYI: I just attached the ASCII logo with 18 characters tall here. |
Hi, thanks for the patience. I have updated branch
I have a patch ready to detect the microarchitecture based on |
Regarding your examples, VisionFive should be ok, but please note that Lichee Pi 4A is wrong (as noted in #219). SoC is system-on-chip so it has nothing to do with the SBC vendor (Milk-V Jupiter in your case). I believe that the right thing would be:
What do you think? Also, is it |
I have pushed a new patch. Please do |
SoC name updated, can you please run ./cpufetch --verbose to see why the microarchitecture is not detected? |
|
Excellent feedback! The patch I have just pushed should work. |
Cool! Just git pull and rebuild again:
Could you also use this new logo file? https://github.com/user-attachments/files/17092416/spacemit2.txt |
@Dr-Noob just saw that you already update i290 |
Getting these 3 RISC-V cpuinfo fields allows the detection of microarchitecture (and other information), extending the RISC-V detection capabilities. In particular, this is used here to detect the marchid of Spacemit X60 uarch. This commit also changes how the microarchitecture is fetched (i.e., get_uarch) so that it does not rely only in the uarch field in cpuinfo, but also on the marchid value.
My bad, I thought I added a comment here after pushing the latest patches. It was a long ride but it's good to see everything is working nicely now! I have added an extra space on the logo and pushed all the changes to master. If you could check one last time to ensure that master works as expected it would be nice. Then we can mark this as completed and close the issue. |
@Dr-Noob Just check the master branch, everything seem fine. I'm closing this issue now. |
Output from
cpufetch --verbose
FYI: SpacemiT M1 is using the same core as K1, but higher frequency.
The text was updated successfully, but these errors were encountered: