Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rockchip rk3588S soc not recognised #188

Closed
Im-0xea opened this issue Aug 10, 2023 · 3 comments
Closed

rockchip rk3588S soc not recognised #188

Im-0xea opened this issue Aug 10, 2023 · 3 comments

Comments

@Im-0xea
Copy link

Im-0xea commented Aug 10, 2023

https://github.com/Im-0xea/cpufetch
@Im-0xea
Copy link
Author

Im-0xea commented Aug 10, 2023

efuse does not seam to be there for rk3588S, that is why im reading from otp

sorry for implenting it for you, I did not read your contributing guidlines before fixing this

Dr-Noob added a commit that referenced this issue Sep 2, 2023
@Dr-Noob
[v1.04][ARM] Add Rockchip 3588S SoC (thanks #188!)
5f5561f
@Dr-Noob
Copy link
Owner

Dr-Noob commented Sep 2, 2023

Interesting! Thanks for your contribution, I just pushed a similar commit. Can you please confirm it also works in your machine?

@Im-0xea
Copy link
Author

Im-0xea commented Sep 3, 2023 •
edited
Loading

Hi! @Dr-Noob,

I currently don't have my rk3588S setup for testing it again

In my opinion there is no need for testing though considering your commit differs to mine in exactly one space for formating

@Im-0xea Im-0xea closed this as completed Sep 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Dr-Noob @Im-0xea