Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial pass at fixing the tests #24

Open
Download opened this issue Jul 24, 2017 · 0 comments
Open

Initial pass at fixing the tests #24

Download opened this issue Jul 24, 2017 · 0 comments
Milestone

Comments

@Download
Copy link
Owner

After we ported the tests, there will probably be many failures, but that's ok as this is test-driven development.

Probably we can fix most tests by porting the code, then are left with some tests either failing because of small differences in test methodology (React Helmet uses some React test tools that don't translate well (or at least I dont know how) to Preact). This issue should fix most tests but it's ok if a bunch are left failing.

We will fix those last tests one by one or maybe even get rid of them if we think it's safe.

@Download Download added this to the v5 milestone Jul 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant