Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

faderbank does not read 14bit data correctly. #195

Open
jpnielsen opened this issue Mar 7, 2024 · 3 comments
Open

faderbank does not read 14bit data correctly. #195

jpnielsen opened this issue Mar 7, 2024 · 3 comments

Comments

@jpnielsen
Copy link

jpnielsen commented Mar 7, 2024

  • OS version: Win 11
  • Rack version: 2.4.1
  • Plugin version: 2.2.7

I compiled and flashed your 14bitCC branch 16n_faderbank_firmware.ino , and it works fine with the "VCV MIDI CC > CV" module, when "14 bit CC 0-31/32-63" is chosen in the module right-click-menu. yay! thanks! 👍

However, "faderbank" seems to swap high7bit and low7bit ? when i move a fader from 0 to 10, the virtual fader moves 0-10, 0-10, 0-10 . . . 127 times.

image

@Dewb
Copy link
Owner

Dewb commented Mar 8, 2024

14-bit faderbank support hasn't been released yet. I hope to get it into the next update of monome-rack! But right now the faderbank 14-bit firmware is an experiment, need to discuss with the maintainers about making it official, and ideally that would happen before the VCV Rack support is finalized. But I might put it out as a beta feature without waiting.

The behavior you're observing is the expected behavior of a non-14-bit-aware receiver listening to the LSB CC, I'm afraid.

If you want to help test, and you're willing to build monome-rack yourself, prototype 14-bit support is in the feat/14bit-fb branch.

@jpnielsen
Copy link
Author

jpnielsen commented Mar 11, 2024

I built 2.2.7 feat/14bit-fb. But it's behaving like before.
(VCV Midi CC > CV is set to 14bit mode).

very small move physical fader 1 can move virtual fader to top.
image

physical fader 1 moved to top.
image

(MSB/LSB swapped?)

@Dewb
Copy link
Owner

Dewb commented Nov 16, 2024

Hi @jpnielsen, what's probably happening here is that the module is still listening to CCs 32-63 in the default configuration, so it's only seeing the LSBs. You need to also pick the 16n under "MIDI output" and then run "Autodetect 16n configuration" so the module knows what CCs to listen to.

Apologies that this isn't more obvious. The next update to this prerelease branch will expand the configuration options to make it clearer what the module is listening for (and allow you to modify the 16n config via sysex, not just receive it.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants