Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long Loading Times #49

Open
DrJacobHolden opened this issue Sep 20, 2017 · 3 comments
Open

Long Loading Times #49

DrJacobHolden opened this issue Sep 20, 2017 · 3 comments

Comments

@DrJacobHolden
Copy link

I am using this plugin and it has added between 1 and 2 seconds to load times for chat windows when I use the Emoji picker component (without the popup helper). When I build the app with Cordova and deploy to an iPhone this can translate to around 15 to 30 seconds of loading. What can I do to make this more efficient? I have tried delaying the appearance of the picker in handlebars but this doesn't seem to work.

@lolmaus
Copy link
Contributor

lolmaus commented Sep 20, 2017

Yeah, current implementation is notoriously slow to render.

I've been thinking how to make it faster, but a substantial improvement that I can think of implies giving up both filtering emoji and highlighting section headers.

Filtering can be replaced with a search, where a new set of emoji is slowly rendered over a fast-rendered full list. This is better because search is delayed and only a subset of a emoji must be rendered.

Highlighting section headers can be replaced with a primitive implementation like must other emoji pickers do.

We have no plans to work on this in the near future.

Meanwhile, you could try reusing a single picker (rendered globally in the application template) instead of prerendering multiple dialogs. Instead of removing it from the DOM when not used, you can hide it with CSS.

@DrJacobHolden
Copy link
Author

Thanks for that - I'll give your suggestion a try.

@gary-menzel
Copy link

Inheriting this for an existing project and, for some reason, the SVG file is taking around 4seconds to load and it loads every single time (it has never loaded quickly since the previous developers were doing the work apparently). We can't really work out why this is happening BUT the link to the demo from github seems to run very quickly - the Chrome console shows NO network activity for the demo.

Are we doing something wrong and Is there a way to pre-load the SVG file to avoid doing a network call ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants