Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrity check for maven, npm and pypi #727

Closed
wants to merge 200 commits into from
Closed

Conversation

mehab
Copy link
Collaborator

@mehab mehab commented Aug 4, 2023

Addresses issue

The integrity check functionality (maven, npm and pypi).
Hyades-apiserver PR: DependencyTrack/hyades-apiserver#261

@sahibamittal sahibamittal requested review from sahibamittal and nscuro and removed request for sahibamittal August 21, 2023 08:48
@sahibamittal sahibamittal changed the title Mavenintegritychecpoc Integrity check for maven, npm and pypi Aug 23, 2023
mehab and others added 17 commits September 12, 2023 12:06
Signed-off-by: mehab <[email protected]>
Bumps `lib.kafka.version` from 3.4.1 to 3.5.0.

Updates `kafka-clients` from 3.4.1 to 3.5.0

Updates `kafka-streams` from 3.4.1 to 3.5.0

Updates `kafka-streams-test-utils` from 3.4.1 to 3.5.0

---
updated-dependencies:
- dependency-name: org.apache.kafka:kafka-clients
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: org.apache.kafka:kafka-streams
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: org.apache.kafka:kafka-streams-test-utils
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: mehab <[email protected]>
Bumps `quarkus.platform.version` from 3.1.0.Final to 3.1.2.Final.

Updates `quarkus-bom` from 3.1.0.Final to 3.1.2.Final
- [Release notes](https://github.com/quarkusio/quarkus/releases)
- [Commits](quarkusio/quarkus@3.1.0.Final...3.1.2.Final)

Updates `quarkus-maven-plugin` from 3.1.0.Final to 3.1.2.Final
- [Commits](quarkusio/quarkus-platform@3.1.0.Final...3.1.2.Final)

Updates `quarkus-container-image-docker` from 3.1.0.Final to 3.1.2.Final

---
updated-dependencies:
- dependency-name: io.quarkus:quarkus-bom
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: io.quarkus.platform:quarkus-maven-plugin
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: io.quarkus:quarkus-container-image-docker
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: mehab <[email protected]>
* Fix broken native images after KStreams upgrade

As of kafka-streams 3.5.0, users can configure a KafkaClientSupplier, with the default implementation being `DefaultKafkaClientSupplier` (https://issues.apache.org/jira/browse/KAFKA-14395).

The supplier is called via reflection, but Quarkus <= 3.1.x doesn't yet register it as such for GraalVM.

Signed-off-by: nscuro <[email protected]>

* Fix failing native image ITs not failing the build

The build was succeeding despite the actual integration tests failing, causing #622 to slip through.

Signed-off-by: nscuro <[email protected]>

---------

Signed-off-by: nscuro <[email protected]>
Signed-off-by: mehab <[email protected]>
Closes #483

Signed-off-by: nscuro <[email protected]>
Signed-off-by: mehab <[email protected]>
Defaults to off in order to be more human-readable.

Example log entry:

```
{"timestamp":"2023-06-23T11:55:24.627+02:00","sequence":2333,"loggerClassName":"org.jboss.logging.Logger","loggerName":"io.quarkus.deployment.dev.RuntimeUpdatesProcessor","level":"INFO","message":"Live reload total time: 1.348s ","threadName":"Aesh InputStream Reader","threadId":91,"mdc":{},"ndc":"","hostName":"ctrl","processName":"mirror-service-dev.jar","processId":33646}
```

Closes #618

Signed-off-by: nscuro <[email protected]>
Signed-off-by: mehab <[email protected]>
…rs in the osv mirror log. Corrected exception message

Signed-off-by: mehab <[email protected]>
The GitHub advisory client loads template files from classpath, which are not packaged into the native image by default.

Signed-off-by: nscuro <[email protected]>
Signed-off-by: mehab <[email protected]>
Signed-off-by: mehab <[email protected]>
Signed-off-by: mehab <[email protected]>
Signed-off-by: mehab <[email protected]>
Signed-off-by: mehab <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Sep 18, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 12 Code Smells

81.6% 81.6% Coverage
3.4% 3.4% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@mehab
Copy link
Collaborator Author

mehab commented Sep 18, 2023

Closing this pull request after reconsidering the design as per requirement of having published date for newly fetched components all the time. Adding the detailed meeting notes on issue #699

@mehab mehab closed this Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants