Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow extraLabels to be set #32

Open
mclueppers opened this issue Apr 22, 2024 · 4 comments
Open

Allow extraLabels to be set #32

mclueppers opened this issue Apr 22, 2024 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers p3 Nice-to-have features size/S Small effort

Comments

@mclueppers
Copy link

Hi,

I'm looking forward to using the Helm charts to deploy DT on my K8s cluster. But my company is usings admission controllers that will verify the existence of particular labels. Since they're not part of the produced templates, I cannot test any deployments. For this reason I'd like to ask for the introduction of extraLabels values key that can accept multiple K/V entries.

@nscuro nscuro added enhancement New feature or request good first issue Good for newcomers p3 Nice-to-have features size/S Small effort labels Apr 22, 2024
@dhalperovich
Copy link

Good day. I would appreciate those extraLabels or podLables as well.

@nscuro
Copy link
Member

nscuro commented Sep 24, 2024

Can we get some clarification as to what the extraLabels need to be applied to? Should there be a global extraLabels variable, or would every resource need separate extraLabels? And for Deployments , Jobs, and StatefulSets, do we need a separate labels value for the Pods they are creating?

@mclueppers
Copy link
Author

IMO we need a global extraLabels that will be set for all resources, and individual extraLabels that can be added on top of the global ones. I personally sometimes use Blue/Green deployments and I toggle active slice at Service level, hence the need for an extra granularity.

@enys
Copy link

enys commented Nov 23, 2024

Extrapolating on this, a common scenario is to add extra labels on the service monitor such as: release: kube-prometheus-stack allowing Prometheus operator to pickup the service monitor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers p3 Nice-to-have features size/S Small effort
Projects
None yet
Development

No branches or pull requests

4 participants