Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "Enable SVG Badge support (unauthenticated)" checkbox to "Enable unauthenticated SVG badge access" as part of deprecation #1009

Closed
2 tasks done
SaberStrat opened this issue Sep 22, 2024 · 0 comments · Fixed by #1019
Labels
enhancement New feature or request
Milestone

Comments

@SaberStrat
Copy link

SaberStrat commented Sep 22, 2024

Current Behavior

Currently, the checkbox controls whether badges are disabled or enabled, but then only as an unauthenticated API.

Proposed Behavior

As the planned support of authentication and authorisation for the Badge API in DependencyTrack/dependency-track#3596 was changed from an immediate breaking change into a deprecation with a grace period before removal, the checkbox won't be removed (#985) during the grace period either.

Instead, as part of the first step of the deprecation, the checkbox shall let the user control whether unauthenticated and unauthorised access to badges is enabled or disabled. In both settings, the Badges API will remain accessible to authenticated and authorised requests--i.e. accessible to requests supplying an API key.

Checklist

@SaberStrat SaberStrat added the enhancement New feature or request label Sep 22, 2024
@SaberStrat SaberStrat changed the title Rename "Enable SVG Badge support (unauthenticated)" checkbox to "Enable unauthenticated SVG Badge support" as part of deprecation Rename "Enable SVG Badge support (unauthenticated)" checkbox to "Enable unauthenticated SVG badge access" as part of deprecation Sep 29, 2024
@nscuro nscuro added this to the 4.12 milestone Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants