Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set_timeseries accepting a float in timeseries parameter #1072

Open
SGeeversAtVortech opened this issue Oct 14, 2018 · 1 comment
Open

set_timeseries accepting a float in timeseries parameter #1072

SGeeversAtVortech opened this issue Oct 14, 2018 · 1 comment

Comments

@SGeeversAtVortech
Copy link
Contributor

In GitLab by @jvande42b on Oct 14, 2018, 17:36

Right now, set_timeseries() accepts as the timeseries:

  1. an array of length self.times()
  2. a timeseries object

Perhaps it would be nice to also be able to accept a single value, e.g. a float? It could treat it the same as if it were an array with all the same value.

@SGeeversAtVortech
Copy link
Contributor Author

In GitLab by @vreeken on Oct 28, 2019, 16:09

For optimization, set_timeseries only accepts a Timeseries. The constructor of Timeseries allows one to broadcast a float.

For simulation, set_timeseries only accepts a numpy array. Hypothetically we could allow a broadcast here. The simulation API is a mess though, so I would hold off until #1126 is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant