Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Numba celltree crashes due to out-of-bounds array access of statically sized stack #22

Closed
smknaake opened this issue Oct 3, 2024 · 1 comment

Comments

@smknaake
Copy link
Contributor

smknaake commented Oct 3, 2024

Using xugrid.OverlapRegridder throws IndexError with mapbox_earcut triangle results from polygons.

Throws: IndexError: index 128 is out of bounds for axis 0 with size 128 which is caused by a pre-allocated array.

Huite added a commit that referenced this issue Oct 3, 2024
Use dynamically sized stack, Issue #22
@Huite
Copy link
Collaborator

Huite commented Oct 3, 2024

Should be fixed by #23

I did a quick benchmark as in #13, checking size seems to make no noticeable difference; and re-allocations will generally be rare.

@Huite Huite closed this as completed Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants