We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
get_driver currently looks like this:
get_driver
from imod_coupler.drivers.metamod.config import MetaModConfig from imod_coupler.drivers.metamod.metamod import MetaMod from imod_coupler.drivers.ribamod.config import RibaModConfig from imod_coupler.drivers.ribamod.ribamod import RibaMod if base_config.driver_type == "metamod": metamod_config = MetaModConfig(config_dir=config_dir, **config_dict["driver"]) return MetaMod(base_config, metamod_config) elif base_config.driver_type == "ribamod": ribamod_config = RibaModConfig(config_dir=config_dir, **config_dict["driver"]) return RibaMod(base_config, ribamod_config) else: raise ValueError(f"Driver type {base_config.driver_type} is not supported.")
It should probably be more like this?
if base_config.driver_type == "metamod": from imod_coupler.drivers.metamod.config import MetaModConfig from imod_coupler.drivers.metamod.metamod import MetaMod metamod_config = MetaModConfig(config_dir=config_dir, **config_dict["driver"]) return MetaMod(base_config, metamod_config) elif base_config.driver_type == "ribamod": from imod_coupler.drivers.ribamod.config import RibaModConfig from imod_coupler.drivers.ribamod.ribamod import RibaMod ribamod_config = RibaModConfig(config_dir=config_dir, **config_dict["driver"]) return RibaMod(base_config, ribamod_config) else: raise ValueError(f"Driver type {base_config.driver_type} is not supported.")
I don't think we want to make ribasim mandatory for everyone who wants to run MetaSWAP.
The text was updated successfully, but these errors were encountered:
No branches or pull requests
get_driver
currently looks like this:It should probably be more like this?
I don't think we want to make ribasim mandatory for everyone who wants to run MetaSWAP.
The text was updated successfully, but these errors were encountered: