Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Externalize duplicate subroutines read_<type>_input(fileid,keyword,value,default) #53

Open
ahmad-el-sayed opened this issue Oct 26, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@ahmad-el-sayed
Copy link
Collaborator

ahmad-el-sayed commented Oct 26, 2023

These are utilities that should be externalized to a dedicated module. Duplicates exist in modules sfincs_snapwave and sfincs_input.

Reason to move to a dedicated module:

  • It is not the responsibility of sfincs_snapwave and sfincs_input modules to provide such functionality
  • Easier maintenance

Note that somehow it is necessary to call notabs in module sfincs_input but it is not in sfincs_snapwave. If this is intended, such call can be controlled via an optional boolean parameter in the signature of read_<type>_input in the unified module.

@ahmad-el-sayed ahmad-el-sayed added the enhancement New feature or request label Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant