Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dimr_config for parallel run with RRcomponent is incorrect #624

Open
MRVermeulenDeltares opened this issue Apr 17, 2024 · 0 comments
Open
Assignees

Comments

@MRVermeulenDeltares
Copy link
Contributor

Describe the bug
In #562 and update was done to improve the writing of the process for the parallel run for the FMcomponent to the dimr_config.
During development of this issue it was discovered that the RRcomponent can also be given a process, as it inherits from abstract component in which process is configured.
When setting the process for the RRcomponent the dimr_config will have the process in the file.

e5poFbAFEW

The RRcomponent however cannot run in parallel, thus this setting is incorrect.
How this should behave is to be further decided, @rhutten.

To Reproduce
The file resulting from the code below contains an invalid entry:

from hydrolib.core.dimr.models import DIMR, FMComponent
fm_comp = RRComponent(name="test", workingDir='.', inputfile='test.mdu',
                      process=4, mpiCommunicator="DFM_COMM_DFMWORLD")
dimr = DIMR(component=fm_comp)
dimr.save(filepath='dimr_config.xml')

Expected behavior
The process should not be written for the RRcomponent to the dimr_config, to be further decided by @rhutten.

Version info (please complete the following information):

  • OS: windows 10
  • Version 0.7.0

Additional context
Based on what is decided, the solution of #562 might help with the implementation of this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants