Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Google SignIn] Simple implementation of Google SignIn #54

Open
DelphiWorlds opened this issue Jul 29, 2021 · 10 comments
Open

[Google SignIn] Simple implementation of Google SignIn #54

DelphiWorlds opened this issue Jul 29, 2021 · 10 comments
Assignees
Labels
enhancement New feature or request priority high Needs urgent attention
Milestone

Comments

@DelphiWorlds
Copy link
Owner

I have working code.. I just need to do some cleaning up and document it :-)

@DelphiWorlds DelphiWorlds self-assigned this Jul 29, 2021
@DelphiWorlds DelphiWorlds added the enhancement New feature or request label Jul 29, 2021
@DelphiWorlds DelphiWorlds added the priority medium Medium priority issue label May 14, 2023
@DelphiWorlds
Copy link
Owner Author

2 years later.. not sure why this was shelved for so long, however the changes in Delphi 11 for Android are going to make it far easier. More in the next week or so..

@DelphiWorlds DelphiWorlds added this to the Google SignIn milestone Jun 12, 2023
@DelphiWorlds
Copy link
Owner Author

OK.. I have code, however the iOS part has been updated to align with GoogleSignIn 2.0.0, and is throwing an AV.

@DelphiWorlds DelphiWorlds added priority high Needs urgent attention and removed priority medium Medium priority issue labels Nov 8, 2023
@DelphiWorlds
Copy link
Owner Author

Just FYI: Still having trouble resolving the issue on iOS 👎

@havrlisan
Copy link

havrlisan commented Feb 6, 2024

Are you still struggling to get it working on iOS? I tested it on Android, and it works great (although I found out there is an additional step to be done if a new project was opened, which is filling in the OAuth consent screen). On iOS though, after the following is executed:

{DW.GoogleSignIn.iOS:143} 
FSignin.signInWithConfiguration(LConfiguration, TiOSHelper.SharedApplication.keyWindow.rootViewController, SignInCallback);

I get this exception:

Project GoogleSignInDemo12 raised exception class EArgumentNilException with message 'Handled null exception'.

@DelphiWorlds
Copy link
Owner Author

I get the same exception - still unable to work out why :-(

@avitos
Copy link

avitos commented Aug 6, 2024

I get the same exception - still unable to work out why :-(

Tried adding on ios, in 11.3 there are inconsistencies in Kastri-master\Features\GoogleSignIn\DW.GoogleSignIn.iOS.pas.
Is Google authorization not available on ios right now? It works fine on Android.

@DelphiWorlds
Copy link
Owner Author

Tried adding on ios, in 11.3 there are inconsistencies in Kastri-master\Features\GoogleSignIn\DW.GoogleSignIn.iOS.pas.

What are the inconsistencies?

Is Google authorization not available on ios right now?

Unfortunately no, but thanks for the reminder - I'll have another look, and see if I can find some help with it

@avitos
Copy link

avitos commented Aug 6, 2024

Got it, thank you very much. It will be great if you can figure it out! I unfortunately don't understand how to make it work.

What are the inconsistencies?

Kastri-master\API\DW.iOSapi.GoogleSignIn.pas does not contain the functions requested by Kastri-master\Features\GoogleSignIn\DW.GoogleSignIn.iOS.pas
Screenshot_458
Screenshot_459

@DelphiWorlds
Copy link
Owner Author

I've pushed an update so that it will at least compile. I expect I had not checked it in because I've been unable to make it work.

@DelphiWorlds
Copy link
Owner Author

Some news: I discovered that the import was incorrect for the version of the Google SignIn framework that was being used. It now no longer crashes, but it also does not show the SignIn prompt. The code has not been checked in yet - I may do so even if I'm unable to get it working, in case someone else can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority high Needs urgent attention
Projects
None yet
Development

No branches or pull requests

3 participants