From 19befe3f362a607c205008be9c11e40011b6112c Mon Sep 17 00:00:00 2001
From: Georg Dangl <georg@dangl.me>
Date: Sat, 30 Mar 2024 14:33:55 +0100
Subject: [PATCH] Resolve warnings

---
 .../BCFTestCases/v2/APIConversion/TestCaseProvider.cs      | 1 -
 .../BCFTestCases/v2/CreateAndExport/BCFv2TestCaseData.cs   | 7 +------
 test/Dangl.BCF.Tests/BCFv2/ProjectExtensionsTests.cs       | 5 +----
 test/Dangl.BCF.Tests/BCFv21/ProjectExtensionsTests.cs      | 5 +----
 test/Dangl.BCF.Tests/BrandingCommentFactoryTests.cs        | 1 -
 test/Dangl.BCF.Tests/Converter/APIFromPhysical.cs          | 3 +--
 test/Dangl.BCF.Tests/Converter/PhysicalFromAPI.cs          | 2 +-
 test/Dangl.BCF.Tests/Dangl.BCF.Tests.csproj                | 6 ++++++
 test/Dangl.BCF.Tests/Properties/AssemblyInfo.cs            | 1 -
 test/Dangl.BCF.Tests/Regression/BcfFileReader.cs           | 5 +----
 10 files changed, 12 insertions(+), 24 deletions(-)

diff --git a/test/Dangl.BCF.Tests/BCFTestCases/v2/APIConversion/TestCaseProvider.cs b/test/Dangl.BCF.Tests/BCFTestCases/v2/APIConversion/TestCaseProvider.cs
index c1126ec..12f1fe0 100644
--- a/test/Dangl.BCF.Tests/BCFTestCases/v2/APIConversion/TestCaseProvider.cs
+++ b/test/Dangl.BCF.Tests/BCFTestCases/v2/APIConversion/TestCaseProvider.cs
@@ -2,7 +2,6 @@
 using System.Collections.Generic;
 using Dangl.BCF.BCFv2;
 using Dangl.BCF.Tests.BCFTestCases.v2.CreateAndExport.Factory;
-using Dangl.BCF.Tests.BCFTestCases.v2.Import;
 
 namespace Dangl.BCF.Tests.BCFTestCases.v2.APIConversion
 {
diff --git a/test/Dangl.BCF.Tests/BCFTestCases/v2/CreateAndExport/BCFv2TestCaseData.cs b/test/Dangl.BCF.Tests/BCFTestCases/v2/CreateAndExport/BCFv2TestCaseData.cs
index 1026809..39681a6 100644
--- a/test/Dangl.BCF.Tests/BCFTestCases/v2/CreateAndExport/BCFv2TestCaseData.cs
+++ b/test/Dangl.BCF.Tests/BCFTestCases/v2/CreateAndExport/BCFv2TestCaseData.cs
@@ -1,9 +1,4 @@
-using System;
-using System.Collections.Generic;
-using System.Linq;
-using System.Threading.Tasks;
-
-namespace Dangl.BCF.Tests.BCFTestCases.v2.CreateAndExport
+namespace Dangl.BCF.Tests.BCFTestCases.v2.CreateAndExport
 {
     public class BcFv2TestCaseData
     {
diff --git a/test/Dangl.BCF.Tests/BCFv2/ProjectExtensionsTests.cs b/test/Dangl.BCF.Tests/BCFv2/ProjectExtensionsTests.cs
index fc2a122..0fe78a6 100644
--- a/test/Dangl.BCF.Tests/BCFv2/ProjectExtensionsTests.cs
+++ b/test/Dangl.BCF.Tests/BCFv2/ProjectExtensionsTests.cs
@@ -1,7 +1,4 @@
-using System;
-using System.Collections.Generic;
-using System.Text;
-using Xunit;
+using Xunit;
 using Dangl.BCF.BCFv2;
 using System.Linq;
 
diff --git a/test/Dangl.BCF.Tests/BCFv21/ProjectExtensionsTests.cs b/test/Dangl.BCF.Tests/BCFv21/ProjectExtensionsTests.cs
index a37eeee..9711fc7 100644
--- a/test/Dangl.BCF.Tests/BCFv21/ProjectExtensionsTests.cs
+++ b/test/Dangl.BCF.Tests/BCFv21/ProjectExtensionsTests.cs
@@ -1,7 +1,4 @@
-using System;
-using System.Collections.Generic;
-using System.Text;
-using Xunit;
+using Xunit;
 using Dangl.BCF.BCFv21;
 using System.Linq;
 
diff --git a/test/Dangl.BCF.Tests/BrandingCommentFactoryTests.cs b/test/Dangl.BCF.Tests/BrandingCommentFactoryTests.cs
index 2302afe..de5dfcb 100644
--- a/test/Dangl.BCF.Tests/BrandingCommentFactoryTests.cs
+++ b/test/Dangl.BCF.Tests/BrandingCommentFactoryTests.cs
@@ -1,6 +1,5 @@
 using System;
 using System.Linq;
-using System.Reflection;
 using System.Text.RegularExpressions;
 using Xunit;
 
diff --git a/test/Dangl.BCF.Tests/Converter/APIFromPhysical.cs b/test/Dangl.BCF.Tests/Converter/APIFromPhysical.cs
index 3297df6..65cda7a 100644
--- a/test/Dangl.BCF.Tests/Converter/APIFromPhysical.cs
+++ b/test/Dangl.BCF.Tests/Converter/APIFromPhysical.cs
@@ -4,14 +4,13 @@
 using Dangl.BCF.BCFv2;
 using Dangl.BCF.BCFv2.Schemas;
 using Dangl.BCF.Converter;
-using Dangl.BCF.Tests.BCFTestCases;
 using Dangl.BCF.Tests.BCFTestCases.v2;
 using Dangl.BCF.Tests.BCFTestCases.v2.CreateAndExport.Factory;
 using Xunit;
 
 namespace Dangl.BCF.Tests.Converter
 {
-    public class APIFromPhysical
+    public static class APIFromPhysical
     {
         public class TestCaxeMaximumInformation
         {
diff --git a/test/Dangl.BCF.Tests/Converter/PhysicalFromAPI.cs b/test/Dangl.BCF.Tests/Converter/PhysicalFromAPI.cs
index af1a528..4968068 100644
--- a/test/Dangl.BCF.Tests/Converter/PhysicalFromAPI.cs
+++ b/test/Dangl.BCF.Tests/Converter/PhysicalFromAPI.cs
@@ -10,7 +10,7 @@
 
 namespace Dangl.BCF.Tests.Converter
 {
-    public class PhysicalFromAPI
+    public static class PhysicalFromAPI
     {
         public class SnapshotConversion
         {
diff --git a/test/Dangl.BCF.Tests/Dangl.BCF.Tests.csproj b/test/Dangl.BCF.Tests/Dangl.BCF.Tests.csproj
index 312742b..fccf0a7 100644
--- a/test/Dangl.BCF.Tests/Dangl.BCF.Tests.csproj
+++ b/test/Dangl.BCF.Tests/Dangl.BCF.Tests.csproj
@@ -9,6 +9,12 @@
     <GenerateAssemblyCompanyAttribute>false</GenerateAssemblyCompanyAttribute>
     <GenerateAssemblyProductAttribute>false</GenerateAssemblyProductAttribute>
   </PropertyGroup>
+  
+  <PropertyGroup>
+    <!-- RCS1155: Warning about using ToUpper instead of invariant comparison -->
+    <!-- RCS1138: Summary comment for XML docs -->
+    <NoWarn>$(NoWarn);RCS1155;RCS1138</NoWarn>
+  </PropertyGroup>
 
   <ItemGroup>
     <EmbeddedResource Include="Resources\**/*" />
diff --git a/test/Dangl.BCF.Tests/Properties/AssemblyInfo.cs b/test/Dangl.BCF.Tests/Properties/AssemblyInfo.cs
index d690e60..10ecfdb 100644
--- a/test/Dangl.BCF.Tests/Properties/AssemblyInfo.cs
+++ b/test/Dangl.BCF.Tests/Properties/AssemblyInfo.cs
@@ -1,5 +1,4 @@
 using System.Reflection;
-using System.Runtime.CompilerServices;
 using System.Runtime.InteropServices;
 
 // General Information about an assembly is controlled through the following
diff --git a/test/Dangl.BCF.Tests/Regression/BcfFileReader.cs b/test/Dangl.BCF.Tests/Regression/BcfFileReader.cs
index 1cfc59b..1d9fa92 100644
--- a/test/Dangl.BCF.Tests/Regression/BcfFileReader.cs
+++ b/test/Dangl.BCF.Tests/Regression/BcfFileReader.cs
@@ -1,7 +1,4 @@
-using System;
-using System.Collections.Generic;
-using System.Text;
-using Xunit;
+using Xunit;
 
 namespace Dangl.BCF.Tests.Regression
 {