Bug: Fix incorrect is_not_null() implementation #553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR running a query like:
Will lead to building a query tree resolving to
NOT (col1 > 2 AND col2 IS NULL)The expected query for this code should have been
col1 > 2 AND NOT (col2 IS NULL)This PR fixes it by introducing a
!prefix on a QueryTree operand, that makes it so the operand gets prepended with anotnode, which how you would expect anis_not_nullto behaveAdded a test for this. Everything in
test_querying.pyafter line 560 is just autoformatting.