Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: Make saving notebooks work on Windows #354

Merged
merged 2 commits into from
Sep 7, 2023
Merged

Bugfix: Make saving notebooks work on Windows #354

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
242b48d
Fix for path handling in save_notebook function
kbolashev Sep 7, 2023
abfd242
Add a warning about only saving the history in jupyter
kbolashev Sep 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions dagshub/notebook.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
import json
import logging
import tempfile
from pathlib import PosixPath
from pathlib import Path, PurePosixPath
from socket import gethostname, gethostbyname

import httpx
Expand Down Expand Up @@ -59,10 +59,11 @@ def save_notebook(repo, path="", branch=None, commit_message=None, versioning='g
return

# Handle file path
file_path = PosixPath(path)
file_path = Path(path)
if file_path.name != "." and "." not in file_path.name:
file_path /= _default_notebook_name()
file_path = "/" / file_path
remote_path = PurePosixPath("/") / file_path.as_posix()

# Handle commit message
if commit_message is None:
Expand All @@ -79,14 +80,18 @@ def save_notebook(repo, path="", branch=None, commit_message=None, versioning='g
out_path = f"{tmp}/{file_path.name}"
if _inside_colab():
from google.colab import _message # If inside colab, this import is guaranteed
notebook_ipynb = _message.blocking_request("get_ipynb")
if notebook_ipynb is None or "ipynb" not in notebook_ipynb:
raise RuntimeError("Couldn't get notebook data from colab.")
with open(out_path, 'w') as file:
file.write(json.dumps(_message.blocking_request('get_ipynb')["ipynb"], indent=4))
file.write(json.dumps(notebook_ipynb["ipynb"], indent=4))
else:
log_message("Saving only the execution history for the notebook in Jupyter environments", logger)
get_ipython().run_line_magic('notebook', out_path)

repo = Repo(owner, repo, branch=branch)
repo.upload(out_path,
remote_path=file_path.as_posix(),
remote_path=remote_path.as_posix(),
commit_message=commit_message,
versioning=versioning,
force=True)
Loading