Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve token handling in the client #342

Merged
merged 3 commits into from
Aug 15, 2023
Merged

Improve token handling in the client #342

merged 3 commits into from
Aug 15, 2023

Conversation

kbolashev
Copy link
Member

This PR adds following behavior:

  • Function for token validity check
  • Automatic removal of expired OAuth tokens from the cache on cache loading
  • When getting a token I now get through all the tokens in the token list until I hit a valid (or a known valid as of previous) token
  • The invalid tokens that were stumbled upon during the get_token process also get removed

This PR does not fix behavior of tokens possibly expiring mid-runtime

@kbolashev kbolashev added the enhancement New feature or request label Aug 15, 2023
@kbolashev kbolashev self-assigned this Aug 15, 2023
@kbolashev kbolashev merged commit a6b69c5 into master Aug 15, 2023
6 checks passed
@kbolashev kbolashev deleted the enhancement/better-token-handling branch August 15, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kbolashev kbolashev

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kbolashev