Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crnlib: don't stop listing files if there is an unknown file type in a directory, skip it #73

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

illwieckz
Copy link
Member

@illwieckz illwieckz commented Sep 26, 2024

Don't stop listing files if there is an unknown file type in a directory, skip it.

@illwieckz
Copy link
Member Author

illwieckz commented Sep 26, 2024

We may have a more generic thinking about what we want there, for example, we may still want to accept some character file so we can convert files by piping them through /dev/stdin or so, or have a more generic thinking about globbing and the waste of listing every parent folder of every file.

But this patch is enough to fix the related bug, where a file cannot be converted because there is a fifo in the same folder.

@illwieckz illwieckz force-pushed the illwieckz/continue-unknown-filetype branch from af6331a to 27a15c6 Compare September 26, 2024 06:39
@illwieckz illwieckz merged commit 573d3ff into master Oct 8, 2024
14 checks passed
@illwieckz illwieckz deleted the illwieckz/continue-unknown-filetype branch October 8, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants