Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consolidate argument checks for predictSolute #222

Open
aappling-usgs opened this issue Aug 17, 2017 · 0 comments
Open

consolidate argument checks for predictSolute #222

aappling-usgs opened this issue Aug 17, 2017 · 0 comments

Comments

@aappling-usgs
Copy link
Contributor

Seems like it ought to be possible to put checks like these:

   # Validate arguments
    flux.or.conc <- match.arg.loadflex(flux.or.conc)
    interval <- match.arg.loadflex(interval)
    attach.units <- match.arg.loadflex(attach.units)
    lin.or.log <- match.arg.loadflex(lin.or.log)
   agg.by <- match.arg(agg.by)

in the generic predictSolute rather than at the top of every predictSolute.xx function. Right? Let's try it. If it doesn't work, make sure agg.by <- match.arg(agg.by) gets into predictSolute.loadLm and predictSolute.loadComp and anywhere else it's currently not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant