Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused ScriptedLoadableModule features #3

Open
allemangD opened this issue Mar 4, 2024 · 0 comments
Open

Remove unused ScriptedLoadableModule features #3

allemangD opened this issue Mar 4, 2024 · 0 comments

Comments

@allemangD
Copy link

One of the nitpick issues mentioned in Slicer/ExtensionsIndex#2006 (review)


Logic classes are CondaSetUpCall and CondaSetUpCallWsl. CondaSetUpLogic is unused, so remove it.


Parameter node is unused - conda settings are persisted in Qt Application settings. I believe this is a correct choice: no conda options should be persisted with the Slicer scene. So remove the logic around parameter node and wrapper.

  • def initializeParameterNode
  • def setParameterNode
  • Logic in exit()
  • Logic in enter()
  • Logic in onSceneStartClose
  • Logic in onSceneEndClose
  • class CondaSetUpParameterNode

Sample data is not used, so remove the sample data from the extension template

  • def registerSampleData
  • Logic in class CondaSetUp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant